fix: Enable clippy::arithmetic_side_effects lint#1119
Merged
Conversation
[This lint](https://rust-lang.github.io/rust-clippy/master/index.html?search=clippy%3A%3Aarithmetic_side_effects#arithmetic_side_effects) warns against using normal math operations, like `+`, `-`, etc. In Rust, these operators panic on overflow in debug builds and overflow in release builds. Enabling this lint forces us to handle potential overflow explicitly. This change enables the lint and fixes the easy violations. Three follow up PRs will address the more complex cases. Ref #1113 Ref [RUST-211](https://linear.app/getsentry/issue/RUST-211/enforce-checked-arithmetic-in-the-sdk)
This was referenced May 6, 2026
lcian
approved these changes
May 7, 2026
szokeasaurusrex
added a commit
that referenced
this pull request
May 7, 2026
Addresses lint violations in sentry/src/transports/ratelimit.rs. Stacked on #1119 Closes #1115 Closes [RUST-212](https://linear.app/getsentry/issue/RUST-212/fix-checked-arithmetic-in-sentrysrctransportsratelimitrs)
szokeasaurusrex
added a commit
that referenced
this pull request
May 11, 2026
Replace unchecked envelope parser offset arithmetic with checked operations and document the invariants that make each addition safe. This removes the file-level lint exception while keeping malformed envelope handling explicit. Stacked on #1119 Closes #1118 Closes [RUST-214](https://linear.app/getsentry/issue/RUST-214/fix-checked-arithmetic-in-sentry-typessrcprotocolenvelopers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lint warns against using normal math operations, like
+,-, etc. In Rust, these operators panic on overflow in debug builds and overflow in release builds. Enabling this lint forces us to handle potential overflow explicitly.This change enables the lint and fixes the easy violations. Three follow up PRs will address the more complex cases.
Ref #1113
Ref RUST-211