Flaky spec fixes #2565
Merged
Flaky spec fixes #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
commented
Feb 24, 2025
| Thread.current.thread_variable_set(Sentry::THREAD_LOCAL, nil) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
I couldn't clear up the worker because we need it on_exit { close } :/
solnic
force-pushed
the
solnic/more-flaky-spec-fixes
branch
from
7c1fed3 to
dabd623
Compare
st0012
approved these changes
Feb 26, 2025
For whatever reason it tried to use master instead of main by default.
This is not needed anymore as we have the new "Tests & CodeCov" workflow.
Co-authored-by: Stan Lo <[email protected]>
solnic
force-pushed
the
solnic/more-flaky-spec-fixes
branch
from
89fae5b to
31e44ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reckon this fixes the most problematic flaky specs that we have now. I could not reproduce the jruby failures locally no matter what I did, so these are still pending. Given that the build passed 3 times in a row here, I feel like this is already very beneficial to merge in.
Refs #2522
#skip-changelog