fix(ci): Support version catalog in android SDK version check#6280
Open
antonis wants to merge 1 commit into
Open
fix(ci): Support version catalog in android SDK version check#6280antonis wants to merge 1 commit into
antonis wants to merge 1 commit into
Conversation
The sentry-android-gradle-plugin moved the bundled SDK version from plugin-build/gradle.properties to gradle/libs.versions.toml in 6.10.0. Fall back to the TOML file when gradle.properties lacks sdk_version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The Danger check
check-android-sdk-mismatch.jsfetches the bundledsentry-androidversion from the gradle plugin repo by readingplugin-build/gradle.properties. Starting with gradle plugin 6.10.0, thesdk_versionproperty was moved togradle/libs.versions.toml(Gradle version catalog), causing the check to fail with:This PR extracts an
fetchFileContenthelper and chains a TOML fallback whengradle.propertiesdoesn't containsdk_version.💡 Motivation and Context
The warning appeared on #6275 (gradle plugin bump to 6.11.0), masking the actual version mismatch info that the check is meant to surface.
💚 How did you test it?
Tested with #6285
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps