Add a first-class expoRouterIntegration() with auto-registration (#6156) #6189
1 issue
code-review: Found 1 issue (1 medium)
Medium
Integration depends on an internal, undocumented expo-router build artifact path - `packages/core/src/js/tracing/expoRouterIntegration.ts:95-99`
Requiring expo-router/build/global-state/router-store accesses a private build artifact that is not part of expo-router's public API; any internal refactor in an expo-router release could silently turn this integration into a no-op with no warning to the user beyond the existing tryGetExpoRouterStore try/catch returning null. Consider tracking the expo-router version range this has been validated against and adding a log when the module is found but the expected shape (store.navigationRef) is absent, to make silent regressions detectable.
⏱ 2m 32s · 482.3k in / 31.6k out · $1.08
Annotations
Check warning on line 99 in packages/core/src/js/tracing/expoRouterIntegration.ts
sentry-warden / warden: code-review
Integration depends on an internal, undocumented expo-router build artifact path
Requiring `expo-router/build/global-state/router-store` accesses a private build artifact that is not part of expo-router's public API; any internal refactor in an expo-router release could silently turn this integration into a no-op with no warning to the user beyond the existing `tryGetExpoRouterStore` try/catch returning `null`. Consider tracking the expo-router version range this has been validated against and adding a log when the module is found but the expected shape (`store.navigationRef`) is absent, to make silent regressions detectable.