Update shellScript value in project.pbxproj to make yarn set-build-number work properly
#5182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld-number` work properly
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 818a608 | 495.84 ms | 498.08 ms | 2.25 ms |
| 8d89cc9+dirty | 537.83 ms | 536.02 ms | -1.81 ms |
| d916aa3 | 425.37 ms | 427.02 ms | 1.65 ms |
| 20d5eaa | 377.62 ms | 406.50 ms | 28.88 ms |
| 1853710 | 555.47 ms | 556.59 ms | 1.12 ms |
| c1573b3 | 400.85 ms | 411.82 ms | 10.97 ms |
| 9f211e3 | 451.50 ms | 500.00 ms | 48.50 ms |
| e2fa43d | 451.68 ms | 462.42 ms | 10.74 ms |
| 7be1f99 | 454.83 ms | 461.36 ms | 6.53 ms |
| 000da7a | 454.46 ms | 445.00 ms | -9.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 818a608 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 8d89cc9+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| d916aa3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 20d5eaa | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 1853710 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| c1573b3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 9f211e3 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| e2fa43d | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 7be1f99 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 000da7a | 17.75 MiB | 19.68 MiB | 1.94 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d916aa3+dirty | 411.72 ms | 451.76 ms | 40.03 ms |
| c9e95bd+dirty | 339.32 ms | 401.24 ms | 61.92 ms |
| c08359e+dirty | 406.04 ms | 428.87 ms | 22.83 ms |
| 8d89cc9+dirty | 357.69 ms | 415.79 ms | 58.10 ms |
| a0b15d6+dirty | 414.33 ms | 448.85 ms | 34.52 ms |
| b3b5b0d+dirty | 361.42 ms | 403.90 ms | 42.48 ms |
| 7be1f99+dirty | 369.02 ms | 399.60 ms | 30.58 ms |
| 20d5eaa+dirty | 358.31 ms | 442.37 ms | 84.06 ms |
| a02e30b+dirty | 346.13 ms | 381.76 ms | 35.62 ms |
| 64cd15c+dirty | 488.79 ms | 483.54 ms | -5.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d916aa3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| c9e95bd+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| c08359e+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 8d89cc9+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| a0b15d6+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| b3b5b0d+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 7be1f99+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 20d5eaa+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a02e30b+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 64cd15c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a+dirty | 1227.71 ms | 1233.72 ms | 6.01 ms |
| ba75c7c+dirty | 1236.14 ms | 1240.69 ms | 4.55 ms |
| 000da7a+dirty | 1204.50 ms | 1218.94 ms | 14.44 ms |
| 23080e5+dirty | 1221.39 ms | 1222.08 ms | 0.70 ms |
| 8ece263+dirty | 1206.90 ms | 1211.45 ms | 4.55 ms |
| eb07ba3+dirty | 1214.49 ms | 1221.59 ms | 7.10 ms |
| d916aa3+dirty | 1211.02 ms | 1221.33 ms | 10.31 ms |
| 3e0a5f9+dirty | 1233.65 ms | 1239.10 ms | 5.45 ms |
| c08359e+dirty | 1200.59 ms | 1211.81 ms | 11.22 ms |
| 64cd15c+dirty | 1213.50 ms | 1223.54 ms | 10.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| ba75c7c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 000da7a+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 23080e5+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 8ece263+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| eb07ba3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| d916aa3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 3e0a5f9+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| c08359e+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 64cd15c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a+dirty | 1233.12 ms | 1233.35 ms | 0.22 ms |
| ba75c7c+dirty | 1235.86 ms | 1226.45 ms | -9.41 ms |
| 000da7a+dirty | 1214.31 ms | 1221.91 ms | 7.61 ms |
| 23080e5+dirty | 1216.02 ms | 1224.94 ms | 8.91 ms |
| 8ece263+dirty | 1217.29 ms | 1213.35 ms | -3.94 ms |
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| d916aa3+dirty | 1221.02 ms | 1228.98 ms | 7.96 ms |
| 3e0a5f9+dirty | 1226.94 ms | 1230.02 ms | 3.08 ms |
| c08359e+dirty | 1235.25 ms | 1233.96 ms | -1.29 ms |
| 64cd15c+dirty | 1216.31 ms | 1214.04 ms | -2.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ba75c7c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 000da7a+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 23080e5+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 8ece263+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| d916aa3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 3e0a5f9+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| c08359e+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 64cd15c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
antonis
reviewed
Sep 19, 2025
| inputFileListPaths = ( | ||
| "${PODS_ROOT}/Target Support Files/Pods-sentryreactnativesample/Pods-sentryreactnativesample-frameworks-${CONFIGURATION}-input-files.xcfilelist", | ||
| ); | ||
| inputPaths = ( |
There was a problem hiding this comment.
q: Are the inputPaths and outputPaths additions needed?
There was a problem hiding this comment.
Nope but they get added automatically by the latest Xcode 😅
|
Thank you for fixing this so quickly @alwx 🙇 |
lucas-zimerman
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
After addressing https://github.com/getsentry/sentry-react-native/pull/5182/files#r2363275623, LGTM!
|
This should also fix a release issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
It's a small kinda bugfix — it updates the value in
shellScriptfor the step called "Bundle React Native code and images" inproject.pbxprojto makeyarn set-build-numberwork properly.To be fair, I think the issue itself is how
yarn set-build-numberworks — but that fix works for now.💡 Motivation and Context
Because we faced the issue with that script here: https://github.com/getsentry/sentry-react-native/actions/runs/17828288487/job/50692368440
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog