fix: Fixes SentryScreenFrames use after being converted to Swift #5153
+50
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaybre
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Fixes SentryScreenFrames use after being converted to Swift ([#5153](https://github.com/getsentry/sentry-react-native/pull/5153))If none of the above apply, you can opt out of this check by adding |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a | 359.51 ms | 374.90 ms | 15.39 ms |
| 785ffb1 | 471.92 ms | 460.96 ms | -10.96 ms |
| d916aa3 | 425.37 ms | 427.02 ms | 1.65 ms |
| ba75c7c | 367.72 ms | 369.16 ms | 1.44 ms |
| 3e0a5f9 | 401.72 ms | 394.98 ms | -6.74 ms |
| eb07ba3 | 470.04 ms | 473.35 ms | 3.31 ms |
| a0b15d6 | 423.06 ms | 437.77 ms | 14.71 ms |
| 46da307 | 455.92 ms | 443.79 ms | -12.13 ms |
| 534ba8c | 484.00 ms | 499.93 ms | 15.93 ms |
| 7be1f99 | 454.83 ms | 461.36 ms | 6.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 785ffb1 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| d916aa3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| ba75c7c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 3e0a5f9 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| eb07ba3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| a0b15d6 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 46da307 | 17.75 MiB | 19.68 MiB | 1.93 MiB |
| 534ba8c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 7be1f99 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 46bd012+dirty | 1220.49 ms | 1226.89 ms | 6.40 ms |
| e2fa43d+dirty | 1216.04 ms | 1232.65 ms | 16.61 ms |
| 7be1f99+dirty | 1226.69 ms | 1217.76 ms | -8.93 ms |
| c08359e+dirty | 1235.25 ms | 1233.96 ms | -1.29 ms |
| 20daa0a+dirty | 1233.12 ms | 1233.35 ms | 0.22 ms |
| af9331b+dirty | 1233.61 ms | 1230.50 ms | -3.11 ms |
| c4e097a+dirty | 1229.09 ms | 1242.61 ms | 13.53 ms |
| ba75c7c+dirty | 1235.86 ms | 1226.45 ms | -9.41 ms |
| 95aaf8a+dirty | 1234.78 ms | 1241.94 ms | 7.16 ms |
| 2b89ce9+dirty | 1229.30 ms | 1239.40 ms | 10.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 46bd012+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| e2fa43d+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 7be1f99+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| c08359e+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 20daa0a+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| af9331b+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| c4e097a+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| ba75c7c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 95aaf8a+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| 2b89ce9+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b89ce9+dirty | 372.22 ms | 417.06 ms | 44.84 ms |
| 23080e5+dirty | 347.29 ms | 381.87 ms | 34.58 ms |
| 98f632c+dirty | 323.98 ms | 375.39 ms | 51.41 ms |
| d916aa3+dirty | 411.72 ms | 451.76 ms | 40.03 ms |
| 46bd012+dirty | 333.76 ms | 359.24 ms | 25.48 ms |
| bc9680d+dirty | 346.77 ms | 463.48 ms | 116.71 ms |
| eb07ba3+dirty | 419.49 ms | 482.12 ms | 62.63 ms |
| ba75c7c+dirty | 377.92 ms | 417.74 ms | 39.83 ms |
| 9f211e3+dirty | 371.00 ms | 432.51 ms | 61.51 ms |
| 5526494+dirty | 380.79 ms | 432.70 ms | 51.91 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b89ce9+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 23080e5+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 98f632c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| d916aa3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 46bd012+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| bc9680d+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| eb07ba3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| ba75c7c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 9f211e3+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 5526494+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 46bd012+dirty | 1231.78 ms | 1212.30 ms | -19.47 ms |
| e2fa43d+dirty | 1224.43 ms | 1235.40 ms | 10.98 ms |
| 7be1f99+dirty | 1222.43 ms | 1217.15 ms | -5.28 ms |
| c08359e+dirty | 1200.59 ms | 1211.81 ms | 11.22 ms |
| 20daa0a+dirty | 1227.71 ms | 1233.72 ms | 6.01 ms |
| af9331b+dirty | 1230.08 ms | 1233.24 ms | 3.16 ms |
| c4e097a+dirty | 1231.35 ms | 1246.91 ms | 15.56 ms |
| ba75c7c+dirty | 1236.14 ms | 1240.69 ms | 4.55 ms |
| 95aaf8a+dirty | 1206.83 ms | 1213.65 ms | 6.81 ms |
| 2b89ce9+dirty | 1241.19 ms | 1254.20 ms | 13.01 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 46bd012+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| e2fa43d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 7be1f99+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| c08359e+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 20daa0a+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| af9331b+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| c4e097a+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| ba75c7c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 95aaf8a+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| 2b89ce9+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
|
Thank you for opening this ahead of the changes Itay. The changes LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
SentryScreenFramesconverted to swift in getsentry/sentry-cocoa#6094