Skip to content

fix(aiohttp): Gate url.full, url.path, url.query on send_default_pii#6650

Merged
ericapisani merged 2 commits into
masterfrom
py-2545-aiohttp-url-attr
Jun 25, 2026
Merged

fix(aiohttp): Gate url.full, url.path, url.query on send_default_pii#6650
ericapisani merged 2 commits into
masterfrom
py-2545-aiohttp-url-attr

forgot to move setting of a url.query behind the pii check

ae3ad30
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: find-bugs completed Jun 24, 2026 in 0s

1 issue

find-bugs: Found 1 issue (1 low)

Low

Test parametrized with send_pii=False never asserts URL attributes are absent on the inner client span - `tests/integrations/aiohttp/test_aiohttp.py:1564-1574`

The if send_pii: block (lines 1564–1574) of test_outgoing_client_span_span_streaming has no else branch, so when send_pii=False the test makes no assertions about url.full, url.path, or url.query on inner_client_span. A regression that leaks these PII attributes regardless of the setting would not be detected by the False parametrization. This is a test coverage gap, not a production defect.


⏱ 14m 16s · 1.2M in / 66.0k out · $1.98