Skip to content

ci: Remove jsonschema from requirements-testing.txt #6620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 4 commits into from
Jun 23, 2026
Merged

ci: Remove jsonschema from requirements-testing.txt #6620

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9435b75
ci: Remove jsonschema from requirements-testing.txt
alexander-alderman-webb Jun 22, 2026
ca7cdd4
import fallback
alexander-alderman-webb Jun 22, 2026
f9457cc
.
alexander-alderman-webb Jun 22, 2026
0c36be5
merge master
alexander-alderman-webb Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements-testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ pytest-forked
pytest-localserver
pytest-timeout
pytest-watch
jsonschema
executing
asttokens
responses
Expand Down
2 changes: 2 additions & 0 deletions scripts/populate_tox/tox.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ deps =

# === Common ===
py3.8-common: hypothesis
common: jsonschema
common: pytest-asyncio
common: httpcore[asyncio]
# See https://github.com/pytest-dev/pytest/issues/9621
Expand All @@ -97,6 +98,7 @@ deps =
# for justification of the upper bound on pytest
{py3.6,py3.7}-gevent: pytest<7.0.0
{py3.8,py3.9,py3.10,py3.11,py3.12}-gevent: pytest
gevent: jsonschema
gevent: pytest-asyncio
gevent: setuptools<82
{py3.10,py3.11}-gevent: zope.event<5.0.0
Expand Down
8 changes: 7 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@
from urllib.parse import parse_qs, urlparse

import brotli
import jsonschema

try:
import jsonschema
except ImportError:
jsonschema = None

import pytest
from pytest_localserver.http import WSGIServer
from werkzeug.wrappers import Request, Response
Expand Down Expand Up @@ -232,6 +237,7 @@ def _capture_internal_warnings():
@pytest.fixture
def validate_event_schema(tmpdir):
def inner(event):
assert jsonschema is not None
if SENTRY_EVENT_SCHEMA:
jsonschema.validate(instance=event, schema=SENTRY_EVENT_SCHEMA)

Expand Down
2 changes: 2 additions & 0 deletions tox.ini
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading