The PR description states tests were added for root_path handling in each ASGI integration, but none of the changed test files (test_asgi.py, test_fastapi.py, test_starlette.py) contain any tests exercising root_path or the EITHER/EXCLUDED enum paths. Have you considered adding at least one test that sets root_path in the ASGI scope and asserts the resulting URL is not duplicated?

The PR adds a root_path_in_path parameter and a _RootPathInPath.EITHER branch in _get_path() (sentry_sdk/integrations/_asgi_common.py) to avoid duplicating scope["root_path"] in URLs. The branch performs non-trivial prefix detection (path.startswith(root_path + "/")) and the Starlette integration selects between EXCLUDED and EITHER based on the Starlette version (>= (0, 33)). Despite the PR description stating that tests were added to each ASGI integration, no test in the suite exercises this logic: there are zero references to root_path in any test file. The version-sensitive, prefix-detecting behavior is therefore regression-prone, with edge cases (e.g. root_path="/api", path="/api-docs") silently untested.

Also found at:

• sentry_sdk/integrations/asgi.py:18
• sentry_sdk/integrations/starlette.py:457
• tests/integrations/starlette/test_starlette.py:1507

In _get_path, when root_path_in_path is EITHER and scope["root_path"] is "/", the guard not root_path or path == root_path or path.startswith(root_path + "/") fails for normal paths: not "/" is False, "/api/users" == "/" is False, and "/api/users".startswith("//") is False. Execution falls through to return root_path + path, yielding "/" + "/api/users" = "//api/users". This produces a malformed URL/transaction name. The ASGI spec says root_path SHOULD NOT end with "/", so this only affects servers that misconfigure root_path as "/" instead of "".

Also found at:

• sentry_sdk/integrations/asgi.py:411