feat(starlette): Support span streaming #6123
Merged
@sentry/warden / warden
completed
Apr 28, 2026 in 1m 15s
1 issue
Medium
Test asserts `middleware.name` attribute that PR description says is `starlette.middleware_name` - `tests/integrations/starlette/test_starlette.py:715-717`
The PR description states the streaming path sets the starlette.middleware_name attribute on middleware spans, but this test asserts span["attributes"]["middleware.name"]. If the integration emits the attribute under the documented key, this assertion will raise KeyError on every iteration and the test will fail. Either the test is checking the wrong key, or the integration is emitting the wrong key — in both cases something is broken.
4 skills analyzed
| Skill | Findings | Duration | Cost |
|---|---|---|---|
| code-review | 0 | 59.1s | $1.18 |
| find-bugs | 1 | 1m 10s | $1.55 |
| skill-scanner | 0 | 36.5s | $0.70 |
| security-review | 0 | 53.6s | $0.75 |
Duration: 3m 39s · Tokens: 902.8k in / 5.8k out · Cost: $4.20 (+dedup: $0.01)
Loading