feat(starlette): Support span streaming #6123
Merged
@sentry/warden / warden
completed
Apr 28, 2026 in 1m 8s
1 issue
Medium
Streaming middleware span uses 'middleware.name' attribute instead of 'starlette.middleware_name' - `sentry_sdk/integrations/starlette.py:178`
Under span streaming, _start_middleware_span sets the attribute key middleware.name, but the legacy non-streaming path (and the PR description) uses the tag key starlette.middleware_name. This inconsistency means consumers/queries that filter by starlette.middleware_name will not match streaming spans, breaking parity with the existing transaction-based path that this PR claims to preserve.
4 skills analyzed
| Skill | Findings | Duration | Cost |
|---|---|---|---|
| code-review | 0 | 1m 5s | $0.91 |
| find-bugs | 1 | 1m 4s | $0.97 |
| skill-scanner | 0 | 22.8s | $0.63 |
| security-review | 0 | 26.6s | $0.65 |
Duration: 2m 59s · Tokens: 680.6k in / 3.7k out · Cost: $3.16 (+extraction: $0.00, +dedup: $0.01)
Loading