Skip to content

ref: Add new_trace, continue_trace to span first (6)#5593

Merged
sentrivana merged 22 commits into
masterfrom
ivana/span-first-6-add-continue-and-new-trace
Mar 9, 2026
Merged

ref: Add new_trace, continue_trace to span first (6)#5593
sentrivana merged 22 commits into
masterfrom
ivana/span-first-6-add-continue-and-new-trace

Merge branch 'master' into ivana/span-first-6-add-continue-and-new-trace

b225c32
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / warden: code-review completed Mar 9, 2026 in 1m 14s

1 issue

code-review: Found 1 issue (1 medium)

Medium

Missing test coverage for new continue_trace and new_trace APIs - `sentry_sdk/traces.py:132-167`

The new continue_trace() and new_trace() functions in sentry_sdk.traces module do not have dedicated test coverage. These functions set propagation context on both isolation and current scopes, which is critical functionality for distributed tracing. Without tests, regressions in trace continuation behavior may go undetected.


Duration: 1m 14s · Tokens: 282.5k in / 2.7k out · Cost: $0.35

Annotations

Check warning on line 167 in sentry_sdk/traces.py

See this annotation in the file changed.

@github-actions github-actions / warden: code-review

Missing test coverage for new continue_trace and new_trace APIs

The new `continue_trace()` and `new_trace()` functions in `sentry_sdk.traces` module do not have dedicated test coverage. These functions set propagation context on both isolation and current scopes, which is critical functionality for distributed tracing. Without tests, regressions in trace continuation behavior may go undetected.