Skip to content

Conversation

shellmayr
Copy link
Member

@shellmayr shellmayr commented Sep 22, 2025

  • This PR makes sure we don't record tool calls as outputs in gen_ai.chat spans in langchain when users deselect the option to include prompts / send pii

Closes TET-1181

Copy link

linear bot commented Sep 22, 2025

Copy link

codecov bot commented Sep 22, 2025

✅ All tests passed in 2567.23s

@shellmayr shellmayr marked this pull request as ready for review September 22, 2025 13:11
@shellmayr shellmayr requested a review from a team as a code owner September 22, 2025 13:11
Copy link

linear bot commented Sep 22, 2025

@alexander-alderman-webb
Copy link
Contributor

My one concern is that I have not heard tool arguments referred to as "prompts". Would users be confused if setting include_prompts=False also hides data from the tool calls?

We could consider more granular setting, especially since I am unsure how intuitive it is for tool call input and outputs to fall under the "prompt" umbrella.

But if that's more niche than we want to cater for, this looks good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants