Skip to content

chore: remove workaround for sentry-dotnet issue #3141 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vaind merged 3 commits into from
Oct 20, 2025
Merged

chore: remove workaround for sentry-dotnet issue #3141 #85

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a1d9ba
chore: remove workaround for sentry-dotnet issue #3141
vaind Jul 11, 2025
8b94b68
chore: changelog
vaind Jul 15, 2025
cc2b10b
Merge branch 'main' into chore/remove-on-exit-flush-workaround
vaind Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixes

- Remove workaround for Dotnet SDK issue causing a hang on process exit - automatic flush should work now. ([#85](https://github.com/getsentry/sentry-powershell/pull/85))
Copy link
Copy Markdown
Member

@Flash0ver Flash0ver Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Swap the two parts of the note so that the actual fix/improvement comes first.

e.g.

Suggested change
- Remove workaround for Dotnet SDK issue causing a hang on process exit - automatic flush should work now. ([#85](https://github.com/getsentry/sentry-powershell/pull/85))
- Automatic flush by removing workaround for Dotnet SDK issue causing a hang on process exit. ([#85](https://github.com/getsentry/sentry-powershell/pull/85))


### Dependencies

- Bump Dotnet SDK from v5.4.0 to v5.12.0 ([#83](https://github.com/getsentry/sentry-powershell/pull/83))
Expand Down
3 changes: 0 additions & 3 deletions modules/Sentry/public/Start-Sentry.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,6 @@ function Start-Sentry
$logger.Log([Sentry.SentryLevel]::Warning, 'Failed to create a PowerShell-specific synchronous worker', $_.Exception, @())
}
}

# Workaround for https://github.com/getsentry/sentry-dotnet/issues/3141
$options.DisableAppDomainProcessExitFlush()
}
process
{
Expand Down
Loading