Skip to content

fix(logs): write nil-event_id-envelopes to random UUID filename #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaMoelans merged 5 commits into from
Jan 7, 2026
Merged

fix(logs): write nil-event_id-envelopes to random UUID filename #1471

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9d2bc3
add event_id to logs envelope
JoshuaMoelans Dec 18, 2025
77d701e
add test for logs+session on Crashpad
JoshuaMoelans Dec 18, 2025
9524e02
extract session/logs from request
JoshuaMoelans Dec 18, 2025
e8d57fe
remove event_id from logs
JoshuaMoelans Dec 19, 2025
43ebf20
generate random UUID for envelopes without event_id
JoshuaMoelans Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/sentry_envelope.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,10 @@ sentry__envelope_add_logs(sentry_envelope_t *envelope, sentry_value_t logs)
return NULL;
}

sentry_uuid_t event_id;
sentry__ensure_event_id(logs, &event_id);
sentry__envelope_set_event_id(envelope, &event_id);

sentry__envelope_item_set_header(
item, "type", sentry_value_new_string("log"));
sentry__envelope_item_set_header(item, "item_count",
Expand Down
Loading