feat(crashpad): Support optional usage of stack pointer for captured stack frame #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
|
Can you update the crashpad submodule so the test suite can run against the current changes on your crashpad PR branch? |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mujacica
force-pushed
the
feat/stack_limit_sp
branch
from
397adf2 to
d536520
Compare
supervacuus
requested changes
Oct 27, 2025
Collaborator
supervacuus
left a comment
supervacuus
left a comment
There was a problem hiding this comment.
Looks largely good, but minor improvements could clarify intent.
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
supervacuus
approved these changes
Oct 28, 2025
JoshuaMoelans
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
crashpadPR: getsentry/crashpad#137