Skip to content

Conversation

@JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Oct 22, 2025

Corresponding crashpad PR: getsentry/crashpad#136

@supervacuus supervacuus marked this pull request as ready for review October 22, 2025 15:14
@supervacuus
Copy link
Collaborator

supervacuus commented Oct 22, 2025

@JoshuaMoelans, please cross-check your review notes to ensure there are no items left before we engage the merge chain. Thx!

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: CMake MSVC Compiler Warning Suppression Issue

The target_compile_options for MSVC in the Crashpad backend uses an invalid COMPILE_LANGUAGE generator expression. CMake's COMPILE_LANGUAGE doesn't accept comma-separated lists like C,CXX, which means the /wd4127 warning suppression isn't applied.

Fix in Cursor Fix in Web

@supervacuus
Copy link
Collaborator

The target_compile_options for MSVC in the Crashpad backend uses an invalid COMPILE_LANGUAGE generator expression. CMake's COMPILE_LANGUAGE doesn't accept comma-separated lists like C,CXX, which means the /wd4127 warning suppression isn't applied.

And once more, with a straight face and not the slightest doubt in tone... 🙄

From the CMake documentation:

1 when the language used for compilation unit matches any of the comma-separated entries in languages, otherwise 0. This expression may be used to specify compile options, compile definitions, and include directories for source files of a particular language in a target.

@JoshuaMoelans JoshuaMoelans merged commit 7e753da into master Oct 23, 2025
66 of 67 checks passed
@JoshuaMoelans JoshuaMoelans deleted the joshua/chore/crashpad_upstream_2025_10_22 branch October 23, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants