Skip to content

fix: prevent crashpad from leaking Objective-C ARC compile options #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supervacuus merged 4 commits into from
Sep 18, 2025
Merged

fix: prevent crashpad from leaking Objective-C ARC compile options #1375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4915dd
fix: prevent crashpad from leaking Objective-C ARC compile options
supervacuus Sep 16, 2025
90e9009
Update CHANGELOG.md
supervacuus Sep 16, 2025
5d8fb8c
Merge branch 'master' into fix/prevent_crashpad_objc_arc_leak
supervacuus Sep 17, 2025
e175963
Merge branch 'master' into fix/prevent_crashpad_objc_arc_leak
supervacuus Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

**Fixes**:

- Include `stddef.h` explicitly in `crashpad` since future `libc++` revisions will stop providing this include transitively. ([#1375](https://github.com/getsentry/sentry-native/pull/1375), [crashpad#132](https://github.com/getsentry/crashpad/pull/132))
- Fall back on `JWASM` in the _MinGW_ `crashpad` build only if _no_ `CMAKE_ASM_MASM_COMPILER` has been defined. ([#1375](https://github.com/getsentry/sentry-native/pull/1375), [crashpad#133](https://github.com/getsentry/crashpad/pull/133))
- Prevent `crashpad` from leaking Objective-C ARC compile options into any parent target linkage. ([#1375](https://github.com/getsentry/sentry-native/pull/1375), [crashpad#134](https://github.com/getsentry/crashpad/pull/134))
- Fixed a TOCTOU race between session init/shutdown and event capture. ([#1377](https://github.com/getsentry/sentry-native/pull/1377))

**Features**:
Expand All @@ -17,6 +20,7 @@
**Internal**:

- Support downstream Xbox SDK specifying networking initialization mechanism. ([#1359](https://github.com/getsentry/sentry-native/pull/1359))
- Added `crashpad` support infrastructure for the external crash reporter feature. ([#1375](https://github.com/getsentry/sentry-native/pull/1375), [crashpad#131](https://github.com/getsentry/crashpad/pull/131))

**Docs**:

Expand Down
2 changes: 1 addition & 1 deletion external/crashpad
Open in desktop
Submodule crashpad updated 27 files
+24 −12 CMakeLists.txt
+13 −1 client/client_argv_handling.cc
+3 −1 client/client_argv_handling.h
+271 −0 client/crash_report_database.cc
+53 −0 client/crash_report_database.h
+21 −0 client/crash_report_database_generic.cc
+25 −0 client/crash_report_database_mac.mm
+34 −0 client/crash_report_database_win.cc
+7 −1 client/crashpad_client.h
+6 −2 client/crashpad_client_linux.cc
+35 −5 client/crashpad_client_mac.cc
+22 −1 client/crashpad_client_win.cc
+20 −2 handler/handler_main.cc
+23 −3 handler/linux/crash_report_exception_handler.cc
+5 −1 handler/linux/crash_report_exception_handler.h
+23 −3 handler/mac/crash_report_exception_handler.cc
+5 −1 handler/mac/crash_report_exception_handler.h
+22 −2 handler/win/crash_report_exception_handler.cc
+5 −1 handler/win/crash_report_exception_handler.h
+1 −0 handler/win/wer/crashpad_wer.cc
+0 −6 third_party/mini_chromium/CMakeLists.txt
+14 −0 third_party/mpack/CMakeLists.txt
+22 −0 third_party/mpack/LICENSE
+14 −0 third_party/mpack/README.crashpad
+7,304 −0 third_party/mpack/mpack.cc
+8,207 −0 third_party/mpack/mpack.h
+1 −2 util/CMakeLists.txt
Loading