compiles on xbox one #1294
compiles on xbox one #1294
Conversation
|
This reverts commit 18541aa.
|
@supervacuus before we move this out of draft (just need some real-device testing IMO), could you take a peek and see if it's OK? |
supervacuus
left a comment
supervacuus
left a comment
There was a problem hiding this comment.
Glad to see that we can reuse the code paths entirely for both Xboxes. One thing that is apparent from the toolchain files for Scarlett and Xbox One is that they are highly similar, and this similarity can be leveraged to halve the required build-script code by extracting a handful of variables. Not necessarily in this PR, but as a sensible follow-up.
| **Features**: | ||
|
|
||
| - Add `sentry_clear_attachments()` to allow clearing all previously added attachments in the global scope. ([#1290](https://github.com/getsentry/sentry-native/pull/1290)) | ||
| - Compiles also on Xbox One ([#1294](https://github.com/getsentry/sentry-native/pull/1294)) |
There was a problem hiding this comment.
The PR says: "feat: xbox one support" but the changelog only mentions compilation. Do you expect another change before Xbox One can be considered supported? I think it should be made clear from the changelog.
There was a problem hiding this comment.
Good point, I made it clear that it's about compilation for now since I can't validate at this point the support. But we'll order a devkit and get this tested at some point and add to docs and communicate things better then.
Thank you!
Support for Xbox One is pretty similar to Xbox Series X|S.
So the changes are mostly pulling more stuff from the GDK samples repo, aligning the cmake files to reduce duplication (thanks @jpnurmi for doing that, and more)
Resolves: https://github.com/getsentry/sentry-xbox/issues/9
Depends on:
Testing will be done on this private repo with self-hosted GHA runner: