feat(ember)!: Update to v2 addon format #19229
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import type ApplicationInstance from '@ember/application/instance'; | ||
| import { instrumentAppInstancePerformance } from '@sentry/ember'; | ||
|
|
||
| export function initialize(appInstance: ApplicationInstance): void { | ||
|
Member
There was a problem hiding this comment. Hey, I am taking another look over this as we are getting closer to planning the next major, where this could go in. Ideally, we'd align this more closely with how we handle sentry init in other places as well - which would be, to keep things centralized in // app.ts
export default class App extends Application {
modulePrefix = config.modulePrefix;
podModulePrefix = config.podModulePrefix;
Resolver = Resolver;
}
Sentry.init({
// ...
integrations: [
Sentry.browserTracingIntegration({ emberApp: App })
]
});and somehow derive/wrap the necessary thing inside of this? That would be the ideal solution IMHO, or something along these lines. then we can also get rid of all the async import and special options for performance etc. and just pass this directly to the (ember-specific) browser tracing integration 🤔
Member
There was a problem hiding this comment. Or alternatively, if this cannot be made to work nicely, we could also do this in the initializer, which would be more "sentry native": import * as Sentry from '@sentry/ember';
export function initialize(appInstance) {
Sentry.addIntegration(Sentry.browserTracingIntegration({
appInstance,
// other options here
});
}this would possibly loose tiny bits of timing info but should overall be likely OK... Then, we need to export a custom
Member
There was a problem hiding this comment. I will look into PRing into this PR some changes for this! |
||
| instrumentAppInstancePerformance(appInstance, { | ||
| minimumRunloopQueueDuration: 0, | ||
| minimumComponentRenderDuration: 0, | ||
| }); | ||
| } | ||
|
aklkv marked this conversation as resolved.
|
||
|
|
||
| export default { | ||
| initialize, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aklkv marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import type ApplicationInstance from '@ember/application/instance'; | ||
| import { instrumentAppInstancePerformance } from '@sentry/ember'; | ||
|
|
||
| export function initialize(appInstance: ApplicationInstance): void { | ||
| instrumentAppInstancePerformance(appInstance, { | ||
| minimumRunloopQueueDuration: 0, | ||
| minimumComponentRenderDuration: 0, | ||
| }); | ||
| } | ||
|
|
||
| export default { | ||
| initialize, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /test-results | ||
| /dist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /** | ||
| * This babel config is used for local tests in the e2e app. | ||
| */ | ||
| const { buildMacros } = require('@embroider/macros/babel'); | ||
|
|
||
| const macros = buildMacros(); | ||
|
|
||
| module.exports = { | ||
| plugins: [ | ||
| [ | ||
| '@babel/plugin-transform-typescript', | ||
| { | ||
| allExtensions: true, | ||
| allowDeclareFields: true, | ||
| onlyRemoveTypeImports: true, | ||
| }, | ||
| ], | ||
| [ | ||
| 'babel-plugin-ember-template-compilation', | ||
| { | ||
| transforms: [...macros.templateMacros], | ||
| }, | ||
| ], | ||
| [ | ||
| 'module:decorator-transforms', | ||
| { | ||
| runtime: { | ||
| import: require.resolve('decorator-transforms/runtime-esm'), | ||
| }, | ||
| }, | ||
| ], | ||
| ...macros.babelMacros, | ||
| ], | ||
| generatorOpts: { | ||
| compact: false, | ||
| }, | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.