-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Ensure http.client
span descriptions don't contain query params or fragments
#15404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
9f55ad3
to
983576e
Compare
983576e
to
c31d665
Compare
s1gr1d
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for all the tests 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an oversight with our
fetch
instrumentation in the core package. where we didn't strip query params and URL hash fragments from the span name (description) ofhttp.client
spans. With this fix, the span description now only contains the URL protocol, host and path as defined in our develop specification.I initially thought this was a regression but after looking through various versions of our browser
fetch
and XHR instrumentations (all the way from v7.0.0 until today), it doesn't seem like we ever sanitized the URLs correctly. I'm not sure what the reason for not including browser was when working on getsentry/team-webplatform-meta#2. At least going forward, this should now be fixed.Affected SDKs:
@sentry/browser
(+SDKs building on it),@sentry/cloudflare
,@sentry/vercel-edge
This PR also adds a bunch of integration and unit tests (also to the unaffected Node SDK) that ensure that the behaviour is aligned in browser and node.
I noticed some discrepancies with span attributes, especially in Otel's node-fetch instrumentation but for now, all required attributes are there as far as I can tell. We can revisit if we get notifications from product that something is missing.
closes #15360