Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay/feedback): Add experimental autoFlushOnFeedback option #15356

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

chargome
Copy link
Member

This PR adds an experimental flag autoFlushOnFeedback to the replay options.

It aims to reduce replays that only contain the user interaction within the feedback modal, whereas the we rather want to inspect what happened prior to this.

Once enabled, replays are automatically flushed when:

  • the feedback modal is opened
  • feedback is captured manually through an api call

partly related to #6908

@chargome chargome self-assigned this Feb 10, 2025
Copy link
Contributor

github-actions bot commented Feb 10, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.9 KB - -
@sentry/browser - with treeshaking flags 22.69 KB - -
@sentry/browser (incl. Tracing) 35.78 KB - -
@sentry/browser (incl. Tracing, Replay) 72.66 KB +0.1% +74 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.14 KB +0.12% +78 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.91 KB +0.1% +78 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.65 KB +0.09% +81 B 🔺
@sentry/browser (incl. Feedback) 39.86 KB +0.04% +13 B 🔺
@sentry/browser (incl. sendFeedback) 27.53 KB - -
@sentry/browser (incl. FeedbackAsync) 32.32 KB - -
@sentry/react 24.74 KB - -
@sentry/react (incl. Tracing) 37.67 KB - -
@sentry/vue 27.1 KB - -
@sentry/vue (incl. Tracing) 37.48 KB - -
@sentry/svelte 22.94 KB - -
CDN Bundle 24.13 KB - -
CDN Bundle (incl. Tracing) 35.85 KB - -
CDN Bundle (incl. Tracing, Replay) 70.55 KB +0.1% +69 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 75.7 KB +0.1% +71 B 🔺
CDN Bundle - uncompressed 70.59 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.47 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.53 KB +0.1% +206 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.09 KB +0.09% +206 B 🔺
@sentry/nextjs (client) 38.64 KB - -
@sentry/sveltekit (client) 36.21 KB - -
@sentry/node 156.35 KB - -
@sentry/node - without tracing 97.33 KB - -
@sentry/aws-serverless 106.84 KB - -

View base workflow run

@chargome chargome marked this pull request as ready for review February 10, 2025 11:26
@chargome chargome requested review from a team as code owners February 10, 2025 11:26
@billyvg
Copy link
Member

billyvg commented Feb 10, 2025

We're going to enable this on Sentry and see how we feel about the replays w/ this turned on -- if satisfied with the results, we'll make this an option that is defaulted to on (and allow users to disable).

@chargome chargome merged commit 2f17ef1 into develop Feb 11, 2025
150 checks passed
@chargome chargome deleted the cg/flush-replay-on-feedback-open branch February 11, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants