feat(flags/v8): add Statsig browser integration #15347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliu39
requested review from
billyvg,
a team,
stephanie-anderson,
andreiborza,
lforst,
AbhiPrasad and
chargome
and removed request for
a team,
stephanie-anderson and
andreiborza
chargome
approved these changes
Feb 10, 2025
billyvg
approved these changes
Feb 10, 2025
| @@ -4,7 +4,7 @@ import { sentryTest } from '../../../../../utils/fixtures'; | |||
|
|
|||
| import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest } from '../../../../../utils/helpers'; | |||
|
|
|||
| const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils. | |||
| import { FLAG_BUFFER_SIZE } from '../../constants'; | |||
There was a problem hiding this comment.
This is fine for this PR, but in the future it'd be better practice to introduce the constant in this PR and do the refactor for the other integrations in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New integration for tracking Statsig js-client flag evaluations, specifically the checkGate method which is used for boolean release flags.
Backports #15319 to v8