test(browser): Avoid making requests to http://example.com
#15059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Jan 17, 2025
| }); | ||
|
|
||
| await getLocalTestUrl({ testDir: __dirname }); | ||
| const requestPromise = page.waitForRequest('http://example.com/api/test/'); |
There was a problem hiding this comment.
this test was previously missing a page.goto call, causing the assertions to not even be executed. Cleaned up the test to ensure that we now actually assert on the headers (and fail if they don't match)
Lms24
commented
Jan 17, 2025
dev-packages/browser-integration-tests/suites/tracing/request/fetch-with-request/init.js
Outdated
Show resolved
Hide resolved
dev-packages/browser-integration-tests/suites/tracing/request/fetch-with-request/subject.js
Outdated
Show resolved
Hide resolved
Lms24
requested review from
a team,
stephanie-anderson,
chargome and
AbhiPrasad
and removed request for
a team and
stephanie-anderson
lforst
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
httpversion of example.com seems to have become unstable, even for the preflight CORS requests the browser makes.This PR adds a couple of
page.routeproxies to ensure we don't actually send requests to example.com.Also, I found a test which previously wasn't failing when the assertions didn't pass