Skip to content

Conversation

stefanosiano
Copy link
Member

📜 Description

SentryAndroid.init now sets strictMode to Lax and reset it after it finishes
Removed few useless IO calls

💡 Motivation and Context

Closes #4261

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review September 12, 2025 14:59
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Sep 12, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 363.56 ms 377.77 ms 14.20 ms
Size 1.58 MiB 2.11 MiB 539.78 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3d205d0 352.15 ms 432.53 ms 80.38 ms
bdbe1f4 380.66 ms 464.44 ms 83.78 ms
9fbb112 359.71 ms 421.85 ms 62.14 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms
3998a95 415.94 ms 478.54 ms 62.60 ms
14ff5ee 419.75 ms 495.73 ms 75.98 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
b750b96 408.98 ms 480.32 ms 71.34 ms
c8125f3 397.65 ms 485.14 ms 87.49 ms
b750b96 421.25 ms 444.09 ms 22.84 ms

App size

Revision Plain With Sentry Diff
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
bdbe1f4 1.58 MiB 2.11 MiB 538.88 KiB
9fbb112 1.58 MiB 2.11 MiB 539.18 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3998a95 1.58 MiB 2.10 MiB 532.96 KiB
14ff5ee 1.58 MiB 2.10 MiB 535.08 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
b750b96 1.58 MiB 2.10 MiB 533.19 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
b750b96 1.58 MiB 2.10 MiB 533.20 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking so you don't accidentally merge since there's one approval already

cursor[bot]

This comment was marked as outdated.

@stefanosiano stefanosiano requested a review from romtsn October 13, 2025 09:43
SentryLevel.WARNING,
"Directory '%s' doesn't exist. No cached events to send.",
SentryLevel.ERROR,
"Cache dir %s is null or is not a directory.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so does listFiles have the isDirectory check under the hood?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. From the javadoc
If this abstract pathname does not denote a directory, then this method returns null

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for introducing the wrapper!

@stefanosiano stefanosiano enabled auto-merge (squash) October 14, 2025 09:15
@stefanosiano stefanosiano merged commit cf708bd into main Oct 14, 2025
60 of 61 checks passed
@stefanosiano stefanosiano deleted the stefanosiano/fix/strict-mode branch October 14, 2025 09:16
@romtsn
Copy link
Member

romtsn commented Oct 14, 2025

@stefanosiano I realized there's a couple of more cases which we didn't cover from the issue:

Installation.id()
AndroidEnvelopeCache.hasStartupCrashMarker

Shall we also wrap them?

@stefanosiano
Copy link
Member Author

@stefanosiano I realized there's a couple of more cases which we didn't cover from the issue:

Installation.id()
AndroidEnvelopeCache.hasStartupCrashMarker

Shall we also wrap them?

Covered in #4809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ten DiskReadViolation's for single SentryAndroid.init

3 participants