feat: Sign macOS builds #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limbonaut
force-pushed
the
feat/sign-macos-builds
branch
2 times, most recently
from
234ef88 to
0e7cb3e
Compare
limbonaut
force-pushed
the
feat/sign-macos-builds
branch
from
0e7cb3e to
65a60c1
Compare
This reverts commit d67abcf.
present on a release branch
|
limbonaut
force-pushed
the
feat/sign-macos-builds
branch
from
9dd0c18 to
7b09380
Compare
limbonaut
force-pushed
the
feat/sign-macos-builds
branch
from
89122d8 to
25f2620
Compare
This reverts commit d8e32ae.
|
Tested and it works. Codesign is performed on release branch only. |
bruno-garcia
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign macOS binaries in CI. The signing process is only executed if the required secrets are accessible. On a release branch, the signing process is mandatory and will terminate with an error if the necessary keys are not provided via secrets.
EDIT: Code signing is now performed on release branch only.