Skip to content

chore(deps): update github.com/stretchr/testify to v1.8.4 #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

hazzik
Copy link
Contributor

@hazzik hazzik commented Apr 2, 2025

Update github.com/stretchr/testify to v1.8.4 to remove circular dependency on github.com/stretchr/objx

@cleptric
Copy link
Member

Thanks for the PR. Any reason not to use 1.10?

@cleptric cleptric self-assigned this Apr 15, 2025
@cleptric cleptric added the Improvement Issue type label Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (7f4ff0a) to head (c7dc78e).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
+ Coverage   83.94%   84.00%   +0.05%     
==========================================
  Files          50       50              
  Lines        5171     5171              
==========================================
+ Hits         4341     4344       +3     
+ Misses        675      673       -2     
+ Partials      155      154       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hazzik
Copy link
Contributor Author

hazzik commented Apr 15, 2025

@cleptric, no particular reason. Was not sure on the package update policy, so just bumped to minimal version where the circular dependency issue was solved.

@cleptric cleptric merged commit c7d162c into getsentry:master May 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Issue type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants