feat: add TagList overload to Metrics-Emit APIs as Attributes parameter#5241
Draft
Flash0ver wants to merge 3 commits into
Draft
feat: add TagList overload to Metrics-Emit APIs as Attributes parameter#5241Flash0ver wants to merge 3 commits into
Flash0ver wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5241 +/- ##
==========================================
+ Coverage 74.13% 74.19% +0.06%
==========================================
Files 508 508
Lines 18282 18312 +30
Branches 3574 3580 +6
==========================================
+ Hits 13553 13587 +34
+ Misses 3860 3851 -9
- Partials 869 874 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an overload to all Metrics method groups (
EmitCounter,EmitGauge,EmitDistribution) that accept Attributes, alongside the existingReadOnlySpan<>andIEnumerable<>overloads.Remarks
TODOs
abstractmethods to a type that is non-constructible by user code, e.g. when having anetstandard2.0library with aPackageReferencetoSentrythat is referenced by anet8.0application that also has aPackageReferencetoSentry