build: download ACKNOWLEDGEMENTS.md for sentry-cli when packing #5231
2 issues
Low
ACKNOWLEDGEMENTS.md downloaded without hash verification before being packed into NuGet - `src/Sentry/Sentry.csproj:135`
The new DownloadFile step for ACKNOWLEDGEMENTS.md is packed into the Sentry NuGet via the existing <None Include="$(SentryCLIDirectory)**" Pack="true" PackagePath="tools\" /> wildcard, but unlike every other SentryCLIDownload item it is not passed through VerifyFileHash. If the Sentry CDN served a tampered file, it would be silently bundled into the published package. Impact is limited because the file is non-executable license-attribution text from Sentry's own CDN, but it diverges from the integrity-check pattern used for the sibling binaries. The PR description already calls this out as temporary pending getsentry/sentry-cli#2823, which publishes the file and (presumably) a hash; once available, add a VerifyFileHash entry for ACKNOWLEDGEMENTS.md alongside removing ContinueOnError.
`chmod +x` applied to ACKNOWLEDGEMENTS.md, marking a text file executable - `src/Sentry/Sentry.csproj:142`
The glob chmod +x $(SentryCLIDirectory)* at line 142 will set the executable bit on ACKNOWLEDGEMENTS.md in addition to the CLI binaries, which is unnecessary and could confuse tooling or audits that scan for unexpected executables in the package.
4 skills analyzed
| Skill | Findings | Duration | Cost |
|---|---|---|---|
| security-review | 0 | 17.6s | $0.04 |
| code-review | 0 | 1.5s | $0.02 |
| find-bugs | 2 | 34.4s | $0.21 |
| gha-security-review | 0 | 2.4s | $0.02 |
⏱ 55.8s · 36.2k in / 2.4k out · $0.29