Skip to content

Merge branch 'main' into chore/enable-changelog-preview-workflow

7b7d2d2
Select commit
Loading
Failed to load commit list.
Draft

chore: enable Changelog Preview workflow #5203

Merge branch 'main' into chore/enable-changelog-preview-workflow
7b7d2d2
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed May 6, 2026 in 34s

1 issue

Medium

pull_request_target with secrets: inherit calls external reusable workflow - `.github/workflows/changelog-preview.yml:18-19`

Enabling this workflow makes it run on every fork PR (including 'edited'/'labeled' events) under pull_request_target, which carries the target repo's secrets. It calls getsentry/craft/.github/workflows/changelog-preview.yml with secrets: inherit, forwarding ALL repository/organization secrets to that external reusable workflow. If the called workflow checks out PR head code, evaluates attacker-controlled inputs (e.g. PR title/body) inside run: blocks, or uses any local action that a fork could override, an external attacker opening a fork PR could exfiltrate the inherited secrets. The action is pinned to a full SHA (good), and permissions are constrained to contents: read/pull-requests: write/statuses: write, which limits but does not eliminate blast radius (PR write enables comment-based exfil/poisoning). Verification of getsentry/craft@bae212c is required — it is in another repo and out of scope for this review per the skill.

4 skills analyzed
Skill Findings Duration Cost
code-review 0 5.0s $0.07
find-bugs 0 4.2s $0.07
gha-security-review 1 31.8s $0.31
security-review 0 4.6s $0.14

Duration: 45.7s · Tokens: 68.4k in / 1.7k out · Cost: $0.59