Skip to content

feat(serilog): support restrictedToMinimumLevel when configuring Seri…

333e6f1
Select commit
Loading
Failed to load commit list.
Open

feat(serilog): support restrictedToMinimumLevel when configuring Serilog in code #5181

feat(serilog): support restrictedToMinimumLevel when configuring Seri…
333e6f1
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed May 4, 2026 in 54s

2 issues

Medium

Filter test has no assertions verifying filtering behavior - `test/Sentry.Serilog.Tests/SentrySerilogSinkExtensionsTests.cs:129-143`

Sentry_WithRestrictedToMinimumLevel_FiltersLogsBelow logs a Warning and an Error but never asserts that the Warning was filtered out by Serilog or that the Error was delivered to the sink. With InitializeSdk = false and no spy/mock sink capturing log events, the test will pass even if restrictedToMinimumLevel is completely ignored. As a result, the new pass-through level functionality is not actually covered by a behavioral test, only by a does-not-throw smoke test.

Low

Sentry_WithRestrictedToMinimumLevel_FiltersLogsBelow asserts nothing about filtering behavior - `test/Sentry.Serilog.Tests/SentrySerilogSinkExtensionsTests.cs:128-144`

The test name claims to verify that logs below the restricted level are filtered before reaching the sink, but the test body contains no assertions verifying this. It only calls logger.Warning and logger.Error without capturing or inspecting which events actually reached the Sentry sink. As a result, the test will pass even if filtering is broken, providing false confidence that the new restrictedToMinimumLevel parameter works correctly.

4 skills analyzed
Skill Findings Duration Cost
code-review 1 25.4s $2.51
find-bugs 1 51.7s $1.03
gha-security-review 0 39.3s $0.52
security-review 0 26.5s $0.64

Duration: 2m 23s · Tokens: 631.6k in / 4.8k out · Cost: $4.70