-
-
Notifications
You must be signed in to change notification settings - Fork 227
Add new .NET 10 Blazor telemetry features example #4769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorSentryIntegration.cs
Show resolved
Hide resolved
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorSentryIntegration.cs
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4769 +/- ##
==========================================
+ Coverage 73.87% 73.91% +0.04%
==========================================
Files 485 485
Lines 17689 17686 -3
Branches 3497 3494 -3
==========================================
+ Hits 13067 13072 +5
+ Misses 3761 3756 -5
+ Partials 861 858 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorEventProcessor.cs
Show resolved
Hide resolved
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorSentryIntegration.cs
Show resolved
Hide resolved
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorSentryIntegration.cs
Show resolved
Hide resolved
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @msuddaby - this is a huge improvement over the sample we had so I'm all good with this. About the only thing that we might want to change is removing the registration of the OTEL metrics as I don't think this is required and adds complexity.
At some stage we could potentially look at using some of this work to build an official integration. It looks like a lot of what you've done to get meaningful names etc. for breadcrumbs could be used to create more meaningful and connected traces. Sentry will be changing how tracing works under the hood though, so we'd probably want to complete that work first.
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorSentryIntegration.cs
Show resolved
Hide resolved
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorSentryIntegration.cs
Show resolved
Hide resolved
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorEventProcessor.cs
Show resolved
Hide resolved
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorSentryIntegration.cs
Show resolved
Hide resolved
samples/Sentry.Samples.AspNetCore.Blazor.Server/Services/BlazorSentryIntegration.cs
Outdated
Show resolved
Hide resolved
Running this locally as CI can't run this on forked contributions
|
@msuddaby this is looking great. There's a problem with our CI servers at the moment, so I also ran Huge thank you for the contribution 🙏🏻 ⭐ 🚀 |
|
@msuddaby, thank you very much for the work you put in to making our samples better. Please reach out to me via Email ( |
As per the discussion in #2329, I've added a few example services to leverage the new .NET 10 Blazor Server telemetry features. These examples demonstrate how they can be used with Sentry.
Improvements:
#skip-changelog