-
-
Notifications
You must be signed in to change notification settings - Fork 223
build: allow local modules/sentry-cocoa
clone for development
#4551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4551 +/- ##
==========================================
- Coverage 73.37% 73.32% -0.05%
==========================================
Files 479 479
Lines 17505 17509 +4
Branches 3445 3445
==========================================
- Hits 12844 12839 -5
- Misses 3783 3790 +7
- Partials 878 880 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
To allow rebuilding sentry-cocoa in local development mode when a locally built .xcframework already exists.
cool ... I'm wondering if it could help to add a section with these instructions to |
I'd propose adding the instructions to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I got a bunch of questions:
Fork [getsentry/perfview](https://github.com/getsentry/perfview/). | ||
Tool from the .NET team which includes several utilities used for profiling .NET code. | ||
We use that in our `Sentry.Profiling` package. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we also miss an entry for sentry-native
... but that's not part of this changeset ... I can follow-up on that afterwards.
✅ |
Hey @jamescrosswell, are you ok with this minor complication of the build system? It's not something one needs for normal .NET development tasks, but it comes in very handy when working on the Cocoa SDK integration. |
Motivation
Instructions
To switch to local development mode, replace the pre-built Sentry Cocoa SDK in
modules/sentry-cocoa
with a clone ofgetsentry/sentry-cocoa
:To switch back to a pre-built Sentry Cocoa SDK, delete the
modules/sentry-cocoa
clone and letSentry.Bindings.Cocoa.csproj
download the version declared inmodules/sentry-cocoa.properties
:#skip-changelog (for internal development purposes only)