feat: add Serilog integration
#4462
Conversation
|
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
|
|
||
| private void CaptureStructuredLog(IHub hub, LogEvent logEvent, string formatted, string? template) | ||
| { | ||
| var traceHeader = hub.GetTraceHeader() ?? SentryTraceHeader.Empty; |
There was a problem hiding this comment.
Is the ParentSpanId required in the protocol for StructuredLogging? An empty SpanId probably isn't that useful otherwise eh?
There was a problem hiding this comment.
No ... it's an optional "Default Attribute" ... the trace_id is required.
Oops ... I made this mistake in the Sentry-SDK and Microsoft.Extensions.Logging integrations, too.
I'll create a follow-up PR to fix this issue in all integrations.
There was a problem hiding this comment.
follow-up for both the SDK-Logger and the Microsoft.Extensions.Logging integration: #4565
|
Looking forward to when this gets out, would really benefit my team |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4462 +/- ##
==========================================
+ Coverage 73.34% 73.45% +0.10%
==========================================
Files 479 480 +1
Lines 17509 17589 +80
Branches 3445 3469 +24
==========================================
+ Hits 12842 12920 +78
+ Misses 3788 3785 -3
- Partials 879 884 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: James Crosswell <[email protected]>
|
Woohoo, thank you again for your amazing efforts out there, @Flash0ver, @jamescrosswell, and team! This will really help out a lot with my projects. 🙏🙏🙏 |
|
release the kraken, I mean nuget package, please? Also idiot proof (I'm the idiot) docs please ❤️ |
|
We got 4 Structured-Logs-related fixes in the pipeline, small yet impactful changes, that I'd like to ship in one release. With 3 developers working on these, I'm confident with releasing early next week. Also, docs are ready to be published too (getsentry/sentry-docs#14693). |
Changes
Add
Serilogintegration to Sentry Structured Logging.Docs
Dogfooding
getsentry/symbol-collector->SymbolCollector.Server