-
-
Notifications
You must be signed in to change notification settings - Fork 224
Add support for net10.0-rc.1 #4461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sactionEndedAsCrashed.DotNet10_0.verified.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops ... sorry ... 22 comments 😟 ... I guess we can do some of these in a follow-up PR ... also lots of questions I am not certain about the change
} | ||
|
||
It 'Ensure System.Reflection.Metadata is not missing' { | ||
It 'Ensure System.Reflection.Metadata is not missing' -Skip:(!$IsWindows) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Did this not fail on Windows before? What has changed? Only on .NET 10? Something we need to follow-up with a fix for in the SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping it for everything except Windows actually:
sentry-dotnet/integration-test/runtime.Tests.ps1
Lines 191 to 193 in f565a5d
It 'Ensure System.Reflection.Metadata is not missing' -Skip:(!$IsWindows) { | |
$path = './net4-console' | |
Remove-Item -Recurse -Force -Path @("$path/bin", "$path/obj") -ErrorAction SilentlyContinue |
The test appears to depend on net4 so Windows only. It might be possible to get it working with mono on other platforms but not sure that's worth the effort. If we do want to do this for some reason, I'd recommend we do it in a follow up PR.
test/Sentry.Extensions.Logging.Tests/Sentry.Extensions.Logging.Tests.csproj
Outdated
Show resolved
Hide resolved
test/Sentry.Google.Cloud.Functions.Tests/Sentry.Google.Cloud.Functions.Tests.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: GitHub <[email protected]>
Co-authored-by: Stefan Pölz <[email protected]>
Initial commit for #4173
Done