Skip to content

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Aug 21, 2025

Initial commit for #4173

Done

  • SentryNoMobile.slnf builds
  • Sentry-CI-Build-macOS.slnf builds (including mobile targets)
  • Sentry-CI-Build-Windows.slnf builds on Windows
  • Unit Tests
  • Integration Tests
  • Trim Tests
  • MSBuild

Initial commit for #4456
- #4456

Currently SentryNoMobile.slnf builds locally... still a bit of work left to get the mobile projects going.
@jamescrosswell jamescrosswell linked an issue Aug 24, 2025 that may be closed by this pull request
4 tasks
Copy link
Member

@Flash0ver Flash0ver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops ... sorry ... 22 comments 😟 ... I guess we can do some of these in a follow-up PR ... also lots of questions I am not certain about the change

}

It 'Ensure System.Reflection.Metadata is not missing' {
It 'Ensure System.Reflection.Metadata is not missing' -Skip:(!$IsWindows) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Did this not fail on Windows before? What has changed? Only on .NET 10? Something we need to follow-up with a fix for in the SDK?

Copy link
Collaborator Author

@jamescrosswell jamescrosswell Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping it for everything except Windows actually:

It 'Ensure System.Reflection.Metadata is not missing' -Skip:(!$IsWindows) {
$path = './net4-console'
Remove-Item -Recurse -Force -Path @("$path/bin", "$path/obj") -ErrorAction SilentlyContinue

The test appears to depend on net4 so Windows only. It might be possible to get it working with mono on other platforms but not sure that's worth the effort. If we do want to do this for some reason, I'd recommend we do it in a follow up PR.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@jamescrosswell jamescrosswell changed the title WIP: Add support for net10.0-rc.1 Add support for net10.0-rc.1 Oct 2, 2025
@jamescrosswell jamescrosswell merged commit 9e2f5f2 into version6 Oct 3, 2025
31 checks passed
@jamescrosswell jamescrosswell deleted the net10 branch October 3, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants