-
-
Notifications
You must be signed in to change notification settings - Fork 223
feat(logs): rework method overloads of Structured Logger #4451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
6 tasks
@sentry review |
Flash0ver
commented
Aug 21, 2025
|
||
namespace Sentry; | ||
|
||
public abstract partial class SentryStructuredLogger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: made class partial
and moved all overloads of the Log{Level}
method groups to a separate document
jamescrosswell
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Sep 11, 2025
This was referenced Sep 12, 2025
This was referenced Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revising the
Log{Level}
methods of the Structured Logger.Breaking Changes in
[Experimental]
featuresNo changes in functionality.
But enables the use of
params
by moving theconfigureLog
parameter to the beginning in a new overload perLog{Level}
method group.Microsoft.Extensions.Logging
chose a similar approach by "prepending" additional parameters in the overloads of theLog{Level}
extension methods.Docs