fix(deno): Preserve npm: specifier in ___SDK_PACKAGE___ for Deno#17673
Merged
Conversation
Deno requires the npm: prefix in import specifiers (e.g. import * as Sentry from "npm:@sentry/deno"), but getSdkPackageName was stripping it from all platforms. Now the prefix is preserved for Deno while all other platforms remain unaffected. This replaces hardcoded "npm:@sentry/deno" imports across Deno platform-includes and docs with the ___SDK_PACKAGE___ placeholder, and adds the Sentry import to the Supabase integration snippet. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
rahulchhabria
approved these changes
May 7, 2026
sentrivana
pushed a commit
that referenced
this pull request
May 18, 2026
) ## DESCRIBE YOUR PR Fixes the root cause of why Deno docs hardcode `import * as Sentry from "npm:@sentry/deno"` instead of using the `___SDK_PACKAGE___` placeholder like all other platforms. The issue: `getSdkPackageName()` strips the `npm:` prefix from the registry canonical value for all platforms. This is correct for Node/Browser/etc (they import from `@sentry/node`), but Deno requires the `npm:` prefix in its import specifiers. - Preserve the `npm:` prefix in `getSdkPackageName` when the platform is Deno - Strip `npm:` in the `PlatformSdkPackageName` display component so prose still shows `@sentry/deno` - Replace all hardcoded `npm:@sentry/deno` imports with `___SDK_PACKAGE___` across 10 content files - Add Sentry import + DSN placeholder to the Supabase integration snippet - Fix typo in Supabase docs ("most use cases. and" → "most use cases and") Supersedes #17562 with a systemic fix instead of a per-page workaround. ## IS YOUR CHANGE URGENT? - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Fixes the root cause of why Deno docs hardcode
import * as Sentry from "npm:@sentry/deno"instead of using the___SDK_PACKAGE___placeholder like all other platforms.The issue:
getSdkPackageName()strips thenpm:prefix from the registry canonical value for all platforms. This is correct for Node/Browser/etc (they import from@sentry/node), but Deno requires thenpm:prefix in its import specifiers.npm:prefix ingetSdkPackageNamewhen the platform is Denonpm:in thePlatformSdkPackageNamedisplay component so prose still shows@sentry/denonpm:@sentry/denoimports with___SDK_PACKAGE___across 10 content filesSupersedes #17562 with a systemic fix instead of a per-page workaround.
IS YOUR CHANGE URGENT?
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: