-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Add iOS auto-update SDK #15711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with two suggestions.
docs/platforms/apple/guides/ios/build-distribution/auto-update.mdx
Outdated
Show resolved
Hide resolved
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one more suggestion.
| Button("Check For Update") { | ||
| let params = CheckForUpdateParams( | ||
| accessToken: "MY_TOKEN", | ||
| organization: "___ORG_SLUG___", | ||
| project: "___PROJECT_SLUG___") | ||
| Updater.checkForUpdate(params: params) { result in | ||
| handleUpdateResult(result: result) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way better thanks
| <Include name="build-distribution/create-integration-token" /> | ||
| 8. Save the new token, you will need it when using the SDK from Swift. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: That's looks very fragile and easy to break when somebody changes the include. I think you should be able to use 1. 1. 1. for all bullet points and markdown will just add the correct numbers for you.
so basically do this in the include
1. Navigate to **Settings > Custom Integrations** in your Sentry organization
1. Click **Create New Integration**

1. Select **Internal Integration** and click **Next**

1. Give your integration a name (e.g., "Build Distribution")

1. Under **Permissions**, select **Read** next to the **Distribution** scope.

1. Click **Save Changes**
1. Scroll down to the Tokens section and click **New Token**

and then
| <Include name="build-distribution/create-integration-token" /> | |
| 8. Save the new token, you will need it when using the SDK from Swift. | |
| <Include name="build-distribution/create-integration-token" /> | |
| 1. Save the new token, you will need it when using the SDK from Swift. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never knew that before, neat!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that didn't work, any idea if there is another way @philipphofmann ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, sorry, then maybe it doesn't work.
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
873cecb to
64c987f
Compare
Bundle ReportChanges will increase total bundle size by 60.27kB (0.17%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
d3e8e0c to
20d84a4
Compare
runningcode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
| } | ||
| ``` | ||
|
|
||
| This expect to find the environment variable `SENTRY_DISTRIBUTION_AUTH_TOKEN`, copy the token you generated in the preceding step to this variable in your CI environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This expect to find the environment variable `SENTRY_DISTRIBUTION_AUTH_TOKEN`, copy the token you generated in the preceding step to this variable in your CI environment. | |
| This expects to find the environment variable `SENTRY_DISTRIBUTION_AUTH_TOKEN`, copy the token you generated in the preceding step to this variable in your CI environment. |
|  | ||
| 1. Click **Save Changes** | ||
| 1. Scroll down to the Tokens section and click **New Token** | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: indentation
|
|
||
| ## Usage | ||
|
|
||
| Use the SDK by calling `Updater.checkForUpdate(params: )`. In addition to the access token, provide your Sentry org and project slug in the CheckForUpdateParams. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with xcode but is there a way to provide a script to xcode that would create a file in the app that would automatically pass these things in?
DESCRIBE YOUR PR
Adding docs for the new update SDK released in iOS v9
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES