Skip to content

feat(ExternalLink) open external links in a new tab #15631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergical merged 1 commit into from
Dec 3, 2025
Merged

feat(ExternalLink) open external links in a new tab #15631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/externalLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ type Props =

export function ExternalLink({children, ...props}: Props) {
return (
<a {...props}>
<a target="_blank" rel="noopener noreferrer" {...props}>
Copy link

@cursor cursor bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Props spread overrides target and rel security attributes

The target="_blank" and rel="noopener noreferrer" attributes are placed before {...props} in the JSX element. In React, later attributes override earlier ones, so any target or rel passed through props will override these values. This contradicts the PR's stated purpose of ensuring external links open in a new tab, and the security protection from rel="noopener noreferrer" can be bypassed. The attributes would need to come after {...props} to be enforced.

Fix in Cursor Fix in Web

Copy link
Member Author

@sergical sergical Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats fine if it needs to be overridden

{children}
<span className="icon icon-external-link">
<svg viewBox="0 0 24 24" width="14" height="14" className="ml-1 inline">
Expand Down
Loading