Skip to content

refactor: migrate android onboarding options to inline syntax #13441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

a-hariti
Copy link
Collaborator

related to #13361

Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 0:13am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 0:13am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 21, 2025 0:13am

Copy link

codecov bot commented Apr 17, 2025

Bundle Report

Changes will decrease total bundle size by 4 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB 2 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
9567.js 11 bytes 19.25kB 0.06%

Files in 9567.js:

  • ./src/rehype-onboarding-lines.js → Total Size: 4.44kB
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/pls8jRBPIir4qW7UAWQge/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/pls8jRBPIir4qW7UAWQge/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/8ha4qGYtCoxbYINskEXfs/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/8ha4qGYtCoxbYINskEXfs/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🛳️

Copy link
Contributor

@stephanie-anderson stephanie-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stephanie-anderson stephanie-anderson merged commit dff51d4 into master Apr 22, 2025
17 checks passed
@stephanie-anderson stephanie-anderson deleted the migrate-onboarding-android branch April 22, 2025 10:30
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
* migrate android onboarding options to inline syntax

* fix option name matcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants