Skip to content

refactor: migrate Python and related guides to the inline product option syntax #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 17, 2025
Merged

refactor: migrate Python and related guides to the inline product option syntax #13412

merged 5 commits into from
Apr 17, 2025

Conversation

a-hariti
Copy link
Collaborator

related to #13361

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs 🛑 Canceled (Inspect) Apr 16, 2025 4:02pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 4:02pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 4:02pm

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/KEFGPT5oVFRiJWH-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/KEFGPT5oVFRiJWH-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/3cD6tJlFRCP0-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/3cD6tJlFRCP0-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

@a-hariti a-hariti changed the title refactor: migrate python and related guides to the inline product option syntax refactor: migrate Python and related guides to the inline product option syntax Apr 16, 2025
antonpirker
antonpirker approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

szokeasaurusrex
szokeasaurusrex requested changes Apr 16, 2025
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice, this new syntax is much cleaner!

However, it seems like you accidentally forgot to add the start/end comments in a few spots – I've commented on the relevant spots. Please fix, then I will approve

szokeasaurusrex
szokeasaurusrex reviewed Apr 16, 2025
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixes look good, but I noticed another small thing

szokeasaurusrex
szokeasaurusrex approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@a-hariti a-hariti merged commit 6f44215 into master Apr 17, 2025
15 checks passed
@a-hariti a-hariti deleted the migrate-onboarding-python branch April 17, 2025 13:48
@a-hariti a-hariti mentioned this pull request Apr 17, 2025
Merged
codyde added a commit that referenced this pull request Apr 19, 2025
@codyde
Merge branch 'master' of https://github.com/getsentry/sentry-docs
47036cb 
* 'master' of https://github.com/getsentry/sentry-docs: (131 commits)
  refactor: migrate Golang and related guides to inline product options syntax (#13413)
  refactor: migrate DotNet sdks to inline product options syntax (#13415)
  add note of the switch sdk (#13431)
  Update spelling in examples.mdx (#13378)
  ref(replay): clarify web & mobile distinction in product docs (#13447)
  fix(java): fix `RestTemplate` auto-instrumentation guide (#13236)
  refactor: migrate Python and related guides to inline product options syntax (#13412)
  Unreal: Document and add `SendDefaultPii = true` to onboarding docs (#13435)
  docs(tracing): Add docs for Previous and Next trace (#13406)
  docs(js): Create Svelte Quick Start guide (#13387)
  Update Profiling SDK version number for iOS/macOS (#13429)
  remove note that workflow notifications alert on new feedback (#13384)
  fix(dart): 404 link (#13430)
  feat(Godot): Update options screenshot on the landing page (#13428)
  add senddefaultpii to powershell (#13426)
  powershell senddefaultpii landing page (#13427)
  chore: update powershell min version requirement (#13425)
  docs(replays): add count_traces to searchable properties (#13422)
  docs(js): Add `sendDefaultPii: true` to all init calls (#13408)
  docs(dotnet): Add `SendDefaultPii = true` option (#13423)
  ...
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
@a-hariti @bitsandfoxes
refactor: migrate Python and related guides to inline product options…
d8b5556 
… syntax (#13412)

* refactor: migrate python and related guides to inline product options syntax

related to #13361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson

@sentrivana sentrivana Awaiting requested review from sentrivana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-hariti @antonpirker @szokeasaurusrex