-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(dart): Add feature flags documentation #13391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(dart): Add feature flags documentation #13391
Conversation
@denrase is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
@buenaflor Think we are rdy for the vercel run? |
Generally looks good to me, since this is part of v9 I won't approve until we've GA'd |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
||
To view the recorded feature flag evaluation, log into [sentry.io](https://sentry.io) and open your project. | ||
|
||
The recorded feature flag evaluations will be visible in the event context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note for the future: We don't support change tracking for Firebase yet.
But once we do, we'll add it to here: https://docs.sentry.io/product/issues/issue-details/feature-flags/#change-tracking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bruno can you clarify - is the wording in the PR ok? because while change tracking is not there, this paragraph talks about evaluation tracking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was just a note for the future. But that makes sense, thanks for pointing out.
It turns out it's not super easy to add Firebase support either and might require the customer to add some firebase lambda in order to call our tracking endpoint. @michellewzhang wrote about it here: https://www.notion.so/sentry/firebase-feature-flag-webhook-1e38b10e4b5d805fb057d2e990ea45e8
I wonder if this is something @aliu39 might be keen to tackle in the future though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added some comments, thanks for adding.
Co-authored-by: Michelle Zhang <[email protected]>
We'll merge this PR as soon as v9 is out |
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Adds docs for Flutter Feature Flag implementation, which will be available in the upcoming v9 release. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## EXTRA RESOURCES - [ [Flutter] Feature Flags Reporting](getsentry/sentry-dart#2746) --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> Co-authored-by: Michelle Zhang <[email protected]>
DESCRIBE YOUR PR
Adds docs for Flutter Feature Flag implementation, which will be available in the upcoming v9 release.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES