Skip to content

feat(platform): Inherit support decision from parent pages #13348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chargome
Copy link
Member

This change will update the logic for rendering pages based on the supported and notSupported frontmatter flags:

  • If the page itself has a support decision this will always take precedence
  • Else we only inspect the support decision of the direct parent (e.g. content/index.mdx is the direct parent of content/subpage.mdx)

This way we prevent rendering child pages of pages that are already excluded.

ref #13322

@chargome chargome self-assigned this Apr 11, 2025
Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 9:48am
sentry-docs ❌ Failed (Inspect) Apr 11, 2025 9:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Apr 11, 2025 9:48am

Copy link

codecov bot commented Apr 11, 2025

Bundle Report

Changes will increase total bundle size by 203 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB 209 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
9567.js 218 bytes 18.95kB 1.16%

Files in 9567.js:

  • ./src/mdx.ts → Total Size: 19.26kB
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/Ve1BMmaGhU6wpuFqGbT_Y/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/Ve1BMmaGhU6wpuFqGbT_Y/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Tfmk8lg0fB0hczD5Y2sfK/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/Tfmk8lg0fB0hczD5Y2sfK/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant