-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs(js): move API-related content from Manual Setup to APIs page #13327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… APIs to APIs page
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
@mydea I leave this pr on Draft for now in case you want to pick it up and fine-tune my API page updates -- let me know :) |
…ick-start/nextjs-manual-clean-up
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
|
||
<SdkApi | ||
name="withServerActionInstrumentation" | ||
signature="function withServerActionInstrumentation(serverActionName: string, options?: Options, callback: A): Promise<ReturnType<A>>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to format this with line breaks similar to the example before it, just for the sake of readability, something like:
function withServerActionInstrumentation(
serverActionName: string,
options?: Options,
callback: A,
): Promise<ReturnType<A>>;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thanks!
I've formatted all the functions I've added so they are more readable now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some formatting suggestions, but overall looks great!
…ick-start/nextjs-manual-clean-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but we need to make this a bit more discoverable as this is an important feature. We still need to add the link in "Next Steps" and maybe also place it somewhere else as well wdyt?
…ick-start/nextjs-manual-clean-up
@chargome yes, thank you! I added the link to Next Steps in both Next.js quick start guides |
DESCRIBE YOUR PR
Added the APIs mentioned from our Next.js manual setup QS guide to the APIs page.
Removed content from Next.js manual setup QS guide we no longer need there (and have documented elsewhere).
Closes: #13289
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES