Skip to content

Prefix firebase remote config feature flags with firebase: #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

Prefix firebase remote config feature flags with firebase: #3258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66a9a25
Prefix firebase remote config feature flags with firebase:
denrase Sep 17, 2025
4d1f84c
add cl entry
denrase Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Enhancements

- Prefix firebase remote config feature flags with `firebase:` ([#3258](https://github.com/getsentry/sentry-dart/pull/3258))

## 9.7.0-beta.5

### Dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_remote_config/lib/src/sentry_firebase_remote_config_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class SentryFirebaseRemoteConfigIntegration extends Integration<SentryOptions> {
for (final updatedKey in updatedKeys) {
final value = _firebaseRemoteConfig.getBoolOrNull(updatedKey);
if (value != null) {
await Sentry.addFeatureFlag(updatedKey, value);
await Sentry.addFeatureFlag('firebase:$updatedKey', value);
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/firebase_remote_config/test/src/sentry_firebase_remote_config_integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ void main() {

expect(featureFlags, isNotNull);
expect(featureFlags?.values.length, 1);
expect(featureFlags?.values.first.flag, 'test');
expect(featureFlags?.values.first.flag, 'firebase:test');
expect(featureFlags?.values.first.result, isFalse);
});

Expand All @@ -105,7 +105,7 @@ void main() {

expect(featureFlags, isNotNull);
expect(featureFlags?.values.length, 1);
expect(featureFlags?.values.first.flag, 'test');
expect(featureFlags?.values.first.flag, 'firebase:test');
expect(featureFlags?.values.first.result, true);
});

Expand Down
Loading