Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Dec 23, 2025

  • Removes the sdk_api_v9.json which is not needed on the v8.x branch anymore
  • Removes broken references in the Xcode project.

#skip-changelog

Closes #7090

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.322%. Comparing base (f73c5c8) to head (dba7609).
⚠️ Report is 1 commits behind head on v8.x.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (f73c5c8) and HEAD (dba7609). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (f73c5c8) HEAD (dba7609)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              v8.x    #7089        +/-   ##
=============================================
- Coverage   85.981%   7.322%   -78.659%     
=============================================
  Files          440      405        -35     
  Lines        27506    26274      -1232     
  Branches     11893     9514      -2379     
=============================================
- Hits         23650     1924     -21726     
- Misses        3813    24339     +20526     
+ Partials        43       11        -32     

see 424 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73c5c8...dba7609. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. When CI is green, LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.60 ms 1254.12 ms 22.52 ms
Size 24.14 KiB 1001.33 KiB 977.19 KiB

Baseline results on branch: v8.x

Startup times

Revision Plain With Sentry Diff
653de7c 1205.02 ms 1222.20 ms 17.18 ms
f73c5c8 1211.10 ms 1234.62 ms 23.51 ms
3af1ae9 1225.60 ms 1252.65 ms 27.05 ms
c21a31f 1237.04 ms 1256.65 ms 19.61 ms
237dfb1 1214.90 ms 1258.63 ms 43.73 ms
c21a31f 1216.02 ms 1236.34 ms 20.32 ms
5e3fb04 1239.84 ms 1267.39 ms 27.55 ms
b66be9b 1218.22 ms 1244.19 ms 25.96 ms
e537c90 1226.22 ms 1256.64 ms 30.41 ms
ab82dac 1249.73 ms 1272.69 ms 22.96 ms

App size

Revision Plain With Sentry Diff
653de7c 23.75 KiB 992.25 KiB 968.50 KiB
f73c5c8 24.14 KiB 1001.32 KiB 977.18 KiB
3af1ae9 23.74 KiB 981.29 KiB 957.55 KiB
c21a31f 23.75 KiB 1000.77 KiB 977.02 KiB
237dfb1 23.75 KiB 1000.79 KiB 977.04 KiB
c21a31f 23.75 KiB 1000.80 KiB 977.05 KiB
5e3fb04 23.74 KiB 981.30 KiB 957.56 KiB
b66be9b 23.75 KiB 996.03 KiB 972.28 KiB
e537c90 23.75 KiB 992.03 KiB 968.28 KiB
ab82dac 23.75 KiB 991.85 KiB 968.10 KiB

Previous results on branch: philprime/v8-cleanup

Startup times

Revision Plain With Sentry Diff
8c512c3 1221.04 ms 1251.47 ms 30.43 ms
0b6a44f 1233.58 ms 1247.23 ms 13.65 ms

App size

Revision Plain With Sentry Diff
8c512c3 24.14 KiB 1001.34 KiB 977.20 KiB
0b6a44f 24.14 KiB 1001.35 KiB 977.21 KiB

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@itaybre itaybre enabled auto-merge (squash) December 23, 2025 20:36
@itaybre itaybre merged commit 48dc176 into v8.x Dec 23, 2025
224 of 229 checks passed
@itaybre itaybre deleted the philprime/v8-cleanup branch December 23, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants