Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Dec 22, 2025

📜 Description

  • Added visionOS 26 configuration to GitHub Actions workflow.
  • Modified various files to support visionOS, including conditional compilation for UIKit and related tests.
  • Updated runtime context for Mac Catalyst to reflect correct descriptions.
  • Enhanced test coverage for device context on visionOS.

💡 Motivation and Context

While working on #6939 I noticed that tests were failing locally, and we didn't even have tests in CI.

💚 How did you test it?

  • Ran unit tests locally
  • Added GitHub Actions workflow

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

@philprime philprime force-pushed the philprime/fix-visionos-tests branch from 983947d to e00f41d Compare December 22, 2025 14:41
@philprime philprime added the ready-to-merge Use this label to trigger all PR workflows label Dec 22, 2025
- Added visionOS 26 configuration to GitHub Actions workflow.
- Modified various files to support visionOS, including conditional compilation for UIKit and related tests.
- Updated runtime context for Mac Catalyst to reflect correct descriptions.
- Enhanced test coverage for device context on visionOS.
@philprime philprime force-pushed the philprime/fix-visionos-tests branch from e00f41d to 96db3d7 Compare December 22, 2025 14:42
@philprime philprime self-assigned this Dec 22, 2025
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.802%. Comparing base (42a9454) to head (9e86389).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7081       +/-   ##
=============================================
- Coverage   84.867%   84.802%   -0.066%     
=============================================
  Files          459       459               
  Lines        27517     27517               
  Branches     12130     12133        +3     
=============================================
- Hits         23353     23335       -18     
+ Misses        4122      3923      -199     
- Partials        42       259      +217     
Files with missing lines Coverage Δ
...ntryTestUtils/Sources/TestDisplayLinkWrapper.swift 89.041% <ø> (ø)

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a9454...9e86389. Read the comment docs.

- Introduced a new destination configuration for visionOS Simulator in the sentry-xcodebuild.sh script.
@philprime philprime marked this pull request as ready for review December 22, 2025 14:53
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.44 ms 1247.19 ms 27.75 ms
Size 24.14 KiB 1.03 MiB 1.00 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
be9107c 1223.63 ms 1242.82 ms 19.19 ms
83cd14a 1195.78 ms 1222.06 ms 26.29 ms
7af87c1 1229.31 ms 1253.84 ms 24.53 ms
7273bf4 1202.42 ms 1227.62 ms 25.21 ms
8047b99 1226.37 ms 1246.63 ms 20.26 ms
b9aacb6 1230.42 ms 1251.00 ms 20.58 ms
cbbc82c 1246.43 ms 1266.13 ms 19.70 ms
fb48c9a 1232.49 ms 1266.27 ms 33.78 ms
83d27f6 1233.56 ms 1259.24 ms 25.68 ms
0b5fd21 1237.52 ms 1251.36 ms 13.84 ms

App size

Revision Plain With Sentry Diff
be9107c 23.75 KiB 975.19 KiB 951.44 KiB
83cd14a 24.14 KiB 1.02 MiB 1022.53 KiB
7af87c1 23.75 KiB 933.34 KiB 909.59 KiB
7273bf4 23.75 KiB 908.01 KiB 884.26 KiB
8047b99 23.75 KiB 855.37 KiB 831.62 KiB
b9aacb6 23.75 KiB 913.64 KiB 889.89 KiB
cbbc82c 23.75 KiB 995.22 KiB 971.47 KiB
fb48c9a 23.75 KiB 1006.34 KiB 982.59 KiB
83d27f6 23.75 KiB 928.88 KiB 905.13 KiB
0b5fd21 23.75 KiB 912.78 KiB 889.03 KiB

Previous results on branch: philprime/fix-visionos-tests

Startup times

Revision Plain With Sentry Diff
c2555ba 1225.02 ms 1255.38 ms 30.35 ms

App size

Revision Plain With Sentry Diff
c2555ba 24.14 KiB 1.03 MiB 1.00 MiB

- Adjusted the runtime context's raw description for Mac Catalyst from "raw_description" to "mac-catalyst-app" in SentryHubTests and SentryCrashWrapperTests.
- Modified conditional compilation in SentrySpan.m to exclude visionOS from UIKit checks.
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime
Copy link
Member Author

need to revisit this PR because I just realized that my conditionals could enable/disable logic

@philprime philprime marked this pull request as draft December 23, 2025 08:43
- Added entry to CHANGELOG for fixing `raw_description` in `runtime` context on Mac Catalyst.
- Adjusted conditional compilation in various test files to improve compatibility with UIKit and visionOS.
Clear app start measurement in setUp() to prevent interference from
previous tests that might have set it. This fixes a visionOS-specific
test failure where testWaitingForFullDisplay_ReportFullDisplayBeforeInitialDisplay
was failing when run with all tests due to incorrect tracer start timestamp.

Also improve assertMeasurement helper to include file/line parameters for
better test failure diagnostics.
@philprime philprime marked this pull request as ready for review December 23, 2025 11:19
@philprime philprime enabled auto-merge (squash) December 23, 2025 11:19
@philprime philprime merged commit 28f150e into main Dec 23, 2025
158 of 159 checks passed
@philprime philprime deleted the philprime/fix-visionos-tests branch December 23, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants