-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Removes HybridSDK subspec #7019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 605fa27 | 1226.31 ms | 1251.35 ms | 25.05 ms |
| 5bc23b4 | 1233.09 ms | 1270.47 ms | 37.38 ms |
| a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
| 69edf86 | 1218.76 ms | 1258.65 ms | 39.90 ms |
| 08fc5f9 | 1237.84 ms | 1270.06 ms | 32.23 ms |
| 781f560 | 1232.83 ms | 1263.56 ms | 30.73 ms |
| d66f082 | 1227.08 ms | 1247.04 ms | 19.96 ms |
| 67e2286 | 1217.83 ms | 1250.04 ms | 32.21 ms |
| ec3fc3a | 1212.92 ms | 1245.06 ms | 32.14 ms |
| 891fd1d | 1220.02 ms | 1227.60 ms | 7.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 605fa27 | 23.75 KiB | 908.03 KiB | 884.28 KiB |
| 5bc23b4 | 24.14 KiB | 1.01 MiB | 1012.90 KiB |
| a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| 69edf86 | 24.14 KiB | 1.01 MiB | 1010.97 KiB |
| 08fc5f9 | 23.75 KiB | 995.43 KiB | 971.68 KiB |
| 781f560 | 23.75 KiB | 1.02 MiB | 1016.46 KiB |
| d66f082 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
| 67e2286 | 24.14 KiB | 1.02 MiB | 1022.54 KiB |
| ec3fc3a | 23.74 KiB | 1022.75 KiB | 999.01 KiB |
| 891fd1d | 23.75 KiB | 919.92 KiB | 896.17 KiB |
Previous results on branch: itay/remove_hybrid_sdk_subspec
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3448221 | 1230.16 ms | 1264.26 ms | 34.10 ms |
| 0438178 | 1228.72 ms | 1257.27 ms | 28.55 ms |
| 45920a9 | 1217.81 ms | 1257.39 ms | 39.58 ms |
| 08ca207 | 1219.10 ms | 1251.02 ms | 31.92 ms |
| adc9c6c | 1219.28 ms | 1246.59 ms | 27.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3448221 | 24.14 KiB | 1.03 MiB | 1.01 MiB |
| 0438178 | 24.14 KiB | 1.03 MiB | 1.00 MiB |
| 45920a9 | 24.14 KiB | 1.02 MiB | 1019.73 KiB |
| 08ca207 | 24.14 KiB | 1.02 MiB | 1019.59 KiB |
| adc9c6c | 24.14 KiB | 1.03 MiB | 1.01 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely add a changelog entry for this.
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for ditching this complexity.
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
This PR is to explore the possibility of removing the HybridSDK subspec since either way all API are public.
This change would also make maintenance easier for the maintainers
More reasons in the decision in #7024