Log Integrations: Add SentryPulse Integration
#7018
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/add-swift-log-integration #7018 +/- ##
====================================================================
+ Coverage 84.936% 85.066% +0.129%
====================================================================
Files 457 454 -3
Lines 27604 27703 +99
Branches 12141 12150 +9
====================================================================
+ Hits 23446 23566 +120
+ Misses 4118 3880 -238
- Partials 40 257 +217 see 71 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
denrase
requested review from
itaybre,
noahsmartin,
philipphofmann and
philprime
as code owners
philprime
left a comment
philprime
left a comment
There was a problem hiding this comment.
LGTM, with one comment to consider
| # Carthage | ||
| # | ||
| # Add this line if you want to avoid checking in source code from Carthage dependencies. | ||
| # Carthage/Checkouts | ||
|
|
||
| Carthage/Build/ |
There was a problem hiding this comment.
We shouldn't need carthage anymore
There was a problem hiding this comment.
@itaybre this gitignore seems to be set up based on my recommendation to use these best-practice gitignores:
https://github.com/github/gitignore/blob/main/Global/macOS.gitignore
https://github.com/github/gitignore/blob/main/Global/Xcode.gitignore
https://github.com/github/gitignore/blob/main/Swift.gitignore
There was a problem hiding this comment.
Yeah i considered removing Carthage, but opted to just keep the file as-is, so we might update more easily if one of those files gets updates.
| # CocoaPods | ||
| # | ||
| # We recommend against adding the Pods directory to your .gitignore. However | ||
| # you should judge for yourself, the pros and cons are mentioned at: | ||
| # https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control | ||
| # | ||
| # Pods/ | ||
| # | ||
| # Add this line if you want to avoid checking in source code from the Xcode workspace | ||
| # *.xcworkspace |
There was a problem hiding this comment.
I think we can also safely remove the Pods folder
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
#skip-changelog
📜 Description
SentryPulseintegration to the3rd-party-integrations/SentryPulsefolder💡 Motivation and Context
Closes #6697
Relates to #6902
💚 How did you test it?
Package.swiftversion📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.