Skip to content

apply feedback from PR review

d73700c
Select commit
Loading
Failed to load commit list.
Open

feat(metrics): Add implementation for metrics envelope item #6960

apply feedback from PR review
d73700c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 22, 2025 in 0s

84.990% (-0.125%) compared to e61661b

View this Pull Request on Codecov

84.990% (-0.125%) compared to e61661b

Details

Codecov Report

❌ Patch coverage is 92.23301% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.990%. Comparing base (e61661b) to head (d73700c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryClient.m 66.666% 4 Missing ⚠️
Sources/Sentry/SentryDataCategoryMapper.m 33.333% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##           philprime/metrics-bootstrap     #6960       +/-   ##
=================================================================
- Coverage                       85.115%   84.990%   -0.125%     
=================================================================
  Files                              461       461               
  Lines                            28043     27730      -313     
  Branches                         12339     12190      -149     
=================================================================
- Hits                             23869     23568      -301     
- Misses                            3916      4123      +207     
+ Partials                           258        39      -219     
Files with missing lines Coverage Δ
SentryTestUtils/Sources/TestClient.swift 86.086% <100.000%> (+0.501%) ⬆️
...ft/Integrations/Metrics/SentryMetricsBatcher.swift 100.000% <100.000%> (ø)
...ntegrations/Metrics/SentryMetricsIntegration.swift 100.000% <100.000%> (ø)
Sources/Swift/Protocol/SentryAttribute.swift 92.187% <ø> (ø)
Sources/Swift/Protocol/SentryMetric.swift 100.000% <100.000%> (ø)
Sources/Swift/Protocol/SentryMetricValue.swift 100.000% <100.000%> (ø)
Sources/Swift/SentryDependencyContainer.swift 98.319% <ø> (-0.977%) ⬇️
Sources/Swift/SentryExperimentalOptions.swift 75.000% <ø> (ø)
Sources/Swift/Tools/Batcher/BatcherScope.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentryClient.m 98.185% <66.666%> (+0.758%) ⬆️
... and 1 more

... and 44 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61661b...d73700c. Read the comment docs.